doc: add missing changelog for #10907 #10919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
approved these changes
Apr 16, 2023
Member
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
Small suggestion for terseness.
Comment on lines
+1
to
+5
| When an exception traceback to be displayed is completely filtered out (by mechanisms such as ``__tracebackhide__``, internal frames, and similar), now only the exception string and the following message are shown: | ||
|
|
||
| "All traceback entries are hidden. Pass `--full-trace` to see hidden and internal frames.". | ||
|
|
||
| Previously, the last frame of the traceback was shown, even though it was hidden. |
Member
There was a problem hiding this comment.
Suggested change
| When an exception traceback to be displayed is completely filtered out (by mechanisms such as ``__tracebackhide__``, internal frames, and similar), now only the exception string and the following message are shown: | |
| "All traceback entries are hidden. Pass `--full-trace` to see hidden and internal frames.". | |
| Previously, the last frame of the traceback was shown, even though it was hidden. | |
| The last frame of the traceback is not mistakenly shown anymore when exceptions tracebacks are completely filtered out (by mechanisms such as ``__tracebackhide__``, internal frames, and similar) without the `--full-trace` option. |
Member
Author
There was a problem hiding this comment.
@Pierre-Sassoulas thanks for the review, the PR was on auto-merge so merged before I could reply.
I did want to explictly mention the complete message, for the benefit of users searching the string in search engines and such.
Member
There was a problem hiding this comment.
Make sense ! No problem it was a nit anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to git add the changelog for #10907.