Add new flag to CLI: --config-file
#11036
Conversation
Signed-off-by: Chris Mahoney <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Chris Mahoney <[email protected]>
nicoddemus
left a comment
There was a problem hiding this comment.
Hi @chrimaho, thanks for the contribution!
However please check your Git settings, both main.py and test_config.py have changed entirely.
|
it seems like the newline convention was changed, wen setting ignore whitespace it gets down to a reasonable diff please fix the newline convention |
- `main.py` to commit SHA `310b67b` - `test_config.py` to commit SHA `407b330`
Signed-off-by: Chris Mahoney <[email protected]>
|
Thank you @nicoddemus and @RonnyPfannschmidt. |
nicoddemus
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Reminder: we should squash this before merging.
|
(Small tip @chrimaho: you can add "Fix #11036" to your PR description to automatically close the issue when it gets merged: https://github.blog/2013-05-14-closing-issues-via-pull-requests/). |
Add new flag to CLI:
--config-fileThere is already an exiting flag in the CLI for importing a custom config file:
-c. This change does not change the behaviour of that flag, but simply adds a new flag to execute the same process:--config-file.This change is also in-line with other large Python packages which use the same behaviour:
--config-file CONFIG_FILE. See here.--config FILE. See here.--config-file#11031