Fix issue where path/to/venv is ignored and an existing venv is used
#114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
path/to/venv is ignored and an existing venv is used
…used, preventing the caller-specified path being used.
Do not rely on a Microsoft Store installed Python
radoering
approved these changes
Aug 15, 2024
Member
radoering
left a comment
There was a problem hiding this comment.
Thanks for analyzing the issue and providing a fix. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #112
I reproduced the issue reported, implemented the fix, then confirmed that the problem is resolved.
I also managed to implement a unit test that covers this scenario, and confirmed that it does indeed fail when the fix is removed.