Add support for dependency groups #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I need this SO BADLY and would be awesome if the PR were accepted. Thanks for the great work |
|
Hello - ➕ this solves a blocking problem for my project. Curious if this is a change you're open to accepting? Thanks! |
|
This looks really helpful! |
radoering
requested changes
Nov 2, 2022
Member
radoering
left a comment
There was a problem hiding this comment.
Sorry for the late feedback. Overall this looks good to me. Can you add some simple tests with the different options in tests/console/commands/bundle/test_venv.py, please?
Contributor
Author
|
I've added the tests as requested. |
radoering
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By making
BundleCommandinherit from poetry'sGroupCommand, and passing the detected groups through to the venv bundler.Fixes #8