-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
gh-130197: Fix (and test) option in pygettext
#133021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
gh-130197: Fix (and test) option in pygettext
#133021
Conversation
Request @tomasr8 @serhiy-storchaka |
edit2: It has now been renamed to exclude-docstrings. This is much clearer (and consistent) that the option needs to be passed something, and is less conflicting with --docstrings. |
ok if we're gonna go with fnmatch, I'd also update the docs for the option to mention that fnmatch-style patterns are supported. I'd also add more tests for wildcards and directories. |
Do we want this though? I guess we can, but should we. |
This also required some updating of the snapshot testing logic to handle multiple files. This function should get more testing and I will come back to this once I complete more research. For now I fixed (and tested) what was implemented.