[language] hl.inline_ctx() for using context manager within Helion kernel device loop (e.g. for TLX async_task)#1389
[language] hl.inline_ctx() for using context manager within Helion kernel device loop (e.g. for TLX async_task)#1389yf225 wants to merge 1 commit into
hl.inline_ctx() for using context manager within Helion kernel device loop (e.g. for TLX async_task)#1389Conversation
2f6d133 to
f110028
Compare
hl.inline_triton_ctx() for context manager within device loophl.inline_triton_ctx() for context manager within device loop
67bca64 to
2357265
Compare
9048420 to
0027111
Compare
hl.inline_triton_ctx() for context manager within device loophl.inline_ctx() for using context manager within Helion kernel
hl.inline_ctx() for using context manager within Helion kernelhl.inline_ctx() for using context manager within Helion kernel (e.g. with tlx.async_task():)
77e3cda to
1caae70
Compare
hl.inline_ctx() for using context manager within Helion kernel (e.g. with tlx.async_task():)hl.inline_ctx() for using context manager within Helion kernel (e.g. for TLX async_task)
d356237 to
c3e903d
Compare
|
Thanks for working on this. Just want to share that besides |
809ab22 to
0dd22b3
Compare
| output_like=None, | ||
| ) | ||
| val = out[tile_m, tile_n] | ||
| out[tile_m, tile_n] = val |
There was a problem hiding this comment.
Diff looks good to me. Looks like we are exposing the partition and the barrier first, the semantics around "out[...] = val" is a bit unclear, does it mean storing to global memory? I saw a similar statement in the compute group.
fbea0f0 to
08fa6d6
Compare
hl.inline_ctx() for using context manager within Helion kernel (e.g. for TLX async_task)hl.inline_ctx() for using context manager within Helion kernel device loop (e.g. for TLX async_task)
08fa6d6 to
41d86c6
Compare
|
Hi @yf225! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
This is for supporting usage of
with tlx.async_task('default'):within Helion kernel, so that TLX kernels using that context manager can be generated by Helion DSL (important for internal customers).