fix: rebenchmark crash during finishing#1523
Conversation
|
learned that reduction_loop is special in terms of getting reset, so skipping minimizing that. |
c8495ec to
64ff80d
Compare
7974589 to
f451c9e
Compare
…uction_loops MagicMock(spec=ConfigSpec) doesn't expose instance attributes set in __init__, so user_defined_tunables needs to be set explicitly on the mock. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
f451c9e to
b4641be
Compare
|
Hi @v0i0! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
apparently, rebenchmark itself will not filter for invalid configs, so we need to do it beforehand.