Unskipping tests on ROCM#1831
Merged
umechand-amd merged 4 commits intoMar 27, 2026
Merged
Conversation
a3fe43e to
f8111b5
Compare
0b1bb88 to
df3eae4
Compare
jansel
approved these changes
Mar 27, 2026
df3eae4 to
8d5f5c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_dot.py : The entire class was skipped based on whether cute is available which seemed incorrect and after unskipping, all the tests either passed or skipped, it seems this skip was added erroneously.
test_examples.py: unskipping fp8 gemm kernel tests which passed and putting the skip triton bug description in skip
test_indexing.py : The skip was because the test was apparently taking too long on Rocm, I reran the test several time on both Mi325 and Mi350, it seemed to finish in relatively the same time as the other tests.