map kernel and copy events to logical stream ID instead of HSA queue ID (#1424)#1424
Closed
hannaxu wants to merge 1 commit into
Closed
map kernel and copy events to logical stream ID instead of HSA queue ID (#1424)#1424hannaxu wants to merge 1 commit into
hannaxu wants to merge 1 commit into
Conversation
|
@hannaxu has exported this pull request. If you are a Meta employee, you can view the originating Diff in D107306915. |
1484cd9 to
7275e8a
Compare
…ID (pytorch#1424) Summary: Previously, `resourceId()` propagated the HSA queue ID for kernel events, rather than the logical stream ID. The AMD default is `GPU_MAX_HW_QUEUES=4`, which follows why stream interleaving was noticeable only when number of workers (total) >= 5 which is common on models with remote (additional remote workers). Therefore, there was stream interleaving as we were mapping > 5 streams to 4 HSA queues. The separate `backfillAsyncCopyStreams` for H2D/D2D was also propagating HW queue IDs. Switch to int64_t for stream ids to avoid truncation; HW queue IDs fit fine in int32. Return streamId with queueId fallback in`resourceId()`. Recover the real HIP stream from the correlated runtime row, resolving both kernels and copies to stream ID via `backfillAsyncStreams`. Remove separate `backfillAsyncCopyStreams`. Async rows carry only the HW queue, so we map correlation --> HIP stream from the runtime rows. *Process* 1. Infer stream from queue when a queue maps unambiguously to one stream 2. Remap raw 64-bit HIP stream pointers to per-device indices since Perfetto misrenders large id values onto the same track 3. Kernels and copies share one per-device index space, so ops on the same HIP stream land on the same track. `resourceId()` returns the resolved streamId with a queueId <--> unambiguous stream map fallback Add the HSA queue ID as a field in the trace, but not as the track provenance in next diff D107568026 Differential Revision: D107306915
7275e8a to
237fc78
Compare
hannaxu
added a commit
to hannaxu/kineto
that referenced
this pull request
Jun 9, 2026
…ID (pytorch#1424) Summary: Previously, `resourceId()` propagated the HSA queue ID for kernel events, rather than the logical stream ID. The AMD default is `GPU_MAX_HW_QUEUES=4`, which follows why stream interleaving was noticeable only when number of workers (total) >= 5 which is common on models with remote (additional remote workers). Therefore, there was stream interleaving as we were mapping > 5 streams to 4 HSA queues. The separate `backfillAsyncCopyStreams` for H2D/D2D was also propagating HW queue IDs. Switch to int64_t for stream ids to avoid truncation; HW queue IDs fit fine in int32. Return streamId with queueId fallback in`resourceId()`. Recover the real HIP stream from the correlated runtime row, resolving both kernels and copies to stream ID via `backfillAsyncStreams`. Remove separate `backfillAsyncCopyStreams`. Async rows carry only the HW queue, so we map correlation --> HIP stream from the runtime rows. *Process* 1. Infer stream from queue when a queue maps unambiguously to one stream 2. Remap raw 64-bit HIP stream pointers to per-device indices since Perfetto misrenders large id values onto the same track 3. Kernels and copies share one per-device index space, so ops on the same HIP stream land on the same track. `resourceId()` returns the resolved streamId with a queueId <--> unambiguous stream map fallback Add the HSA queue ID as a field in the trace, but not as the track provenance in next diff D107568026 Differential Revision: D107306915
sanrise
approved these changes
Jun 9, 2026
sanrise
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for adding this -
|
This pull request has been merged in 25856f7. |
scotts
added a commit
to scotts/pytorch
that referenced
this pull request
Jun 16, 2026
Includes the following commits: - surface HSA queue ID (pytorch/kineto#1425) 1d43601 - Add TypedMetadata to CUPTI activities (pytorch/kineto#1434) 461a26c - Move around methods so they are accurately described by the comments (pytorch/kineto#1435) ff95265 - Introduce TypedMetadata structs (pytorch/kineto#1433) 965a14d - Add unit tests for sync/async interleaving behavior (pytorch/kineto#1431) 67612e6 - Restrict on-demand trace output path to a safe directory (pytorch/kineto#1426) 9ea826e - Add a cancellation state to the state machine and remove syncTraceActive_ (pytorch/kineto#1355) 3289139 - Move state machine from profiler into async handler (pytorch/kineto#1352) eb578c5 - map kernel and copy events to logical stream ID instead of HSA queue ID (pytorch/kineto#1424) 25856f7 - Speedup and fix PyTorch CI build (pytorch/kineto#1428) e675bbb - Add logging for async rejections (pytorch/kineto#1422) 14becfb - Make sure we clear the logger observer before starting a new session (pytorch/kineto#1387) a8cae92 - Add a scope guard for logging to help us capture all exit paths (pytorch/kineto#1383) ce13b13 - Remove roctracer support (pytorch/kineto#1419) 2a3a002
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Jun 16, 2026
Includes the following commits: - surface HSA queue ID (pytorch/kineto#1425) 1d43601 - Add TypedMetadata to CUPTI activities (pytorch/kineto#1434) 461a26c - Move around methods so they are accurately described by the comments (pytorch/kineto#1435) ff95265 - Introduce TypedMetadata structs (pytorch/kineto#1433) 965a14d - Add unit tests for sync/async interleaving behavior (pytorch/kineto#1431) 67612e6 - Restrict on-demand trace output path to a safe directory (pytorch/kineto#1426) 9ea826e - Add a cancellation state to the state machine and remove syncTraceActive_ (pytorch/kineto#1355) 3289139 - Move state machine from profiler into async handler (pytorch/kineto#1352) eb578c5 - map kernel and copy events to logical stream ID instead of HSA queue ID (pytorch/kineto#1424) 25856f7 - Speedup and fix PyTorch CI build (pytorch/kineto#1428) e675bbb - Add logging for async rejections (pytorch/kineto#1422) 14becfb - Make sure we clear the logger observer before starting a new session (pytorch/kineto#1387) a8cae92 - Add a scope guard for logging to help us capture all exit paths (pytorch/kineto#1383) ce13b13 - Remove roctracer support (pytorch/kineto#1419) 2a3a002 Pull Request resolved: #187440 Approved by: https://github.com/ryanzhang22, https://github.com/Skylion007
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Previously,
resourceId()propagated the HSA queue ID for kernel events, rather than the logical stream ID. The AMD default isGPU_MAX_HW_QUEUES=4, which follows why stream interleaving was noticeable only when number of workers (total) >= 5 which is common on models with remote (additional remote workers). Therefore, there was stream interleaving as we were mapping > 5 streams to 4 HSA queues. The separatebackfillAsyncCopyStreamsfor H2D/D2D was also propagating HW queue IDs.Switch to int64_t for stream ids to avoid truncation; HW queue IDs fit fine in int32. Return streamId with queueId fallback in
resourceId(). Recover the real HIP stream from the correlated runtime row, resolving both kernels and copies to stream ID viabackfillAsyncStreams. Remove separatebackfillAsyncCopyStreams. Async rows carry only the HW queue, so we map correlation --> HIP stream from the runtime rows.Process
resourceId()returns the resolved streamId with a queueId <--> unambiguous stream map fallbackAdd the HSA queue ID as a field in the trace, but not as the track provenance in next diff D107568026
Differential Revision: D107306915