Pass Rscript options through ir run - #13
Merged
Merged
Conversation
…ir-run # Conflicts: # src/main.rs
cderv
added a commit
that referenced
this pull request
Jun 3, 2026
t-kalinowski
added a commit
that referenced
this pull request
Jun 4, 2026
* Add design spec for ir run on Quarto documents * Rebase spec onto merged #14 and align arg handling with #13 * Refine quarto run spec per design review Resolve quarto-check timing, QUARTO_R conditional setting, comma-arg rejection, extensionless-script dispatch, and frontmatter-fence edges. * Add implementation plan for ir run on Quarto documents * Ignore roborev snapshot directory * Fix two plan-doc defects from branch design review Comma-bearing Rscript options are now rejected in cmd_run before phase-1 resolution rather than inside run_quarto. As written, resolution ran first, so the comma-rejection test (whose fake resolver fails loudly) never reached the check and its "resolver never runs" comment was false; failing fast also avoids resolving packages for a run that can never launch. Multi-filter `cargo test` verification commands now pass filters after `--`; cargo's [TESTNAME] takes a single value and errored on the second filter. * Add IR_QUARTO seam and Windows/.Rmd test coverage Selecting the quarto executable now mirrors the IR_RSCRIPT seam: IR_QUARTO if set, else bare `quarto` on PATH. This closes a real Windows gap surfaced while adding the reviewer-requested Windows coverage — Rust's bare-name PATH search resolves only quarto.exe (it does not consult PATHEXT), so a dev quarto.cmd was unreachable; IR_QUARTO with a full path selects it (and lets tests fake quarto without touching PATH). Also folds in the spec wording precision (R_LIBS is the only env var conditional on dependency resolution, not the sole conditional one) and adds explicit .Rmd-routing and Windows run_quarto integration tests. * Parse frontmatter from the ir: key for nested documents * Extract the leading YAML block from Quarto documents * Add run_quarto and its QUARTO_R and launch helpers * Dispatch .qmd and .Rmd targets to quarto render * Document Quarto document support * Support r-version/exclude-newer for Quarto documents after rig rebase Rebasing the Quarto support onto #18 (rig-backed R resolution) means a Quarto document's `ir:` block can now declare `r-version` and `exclude-newer` alongside `dependencies`, exactly as a script does. `rscript_for_spec` selects the rig R, and because that one Rscript feeds both phase-1 resolution and `QUARTO_R`, the document renders with the same R it was resolved against — the same-R invariant the design called for, now satisfied through rig rather than a bare PATH `Rscript`. The merged help/README text kept the pre-#18 frontmatter keys; correct the Quarto README example to `r-version`/`exclude-newer` and note that the `ir:` block accepts the same fields as a script. Add a cfg(unix) test that fakes rig + quarto to prove an `ir.r-version` document pins QUARTO_R to the rig-selected Rscript, and gate the merged unix-only `prepend_path` helper so `clippy --all-targets` stays clean on Windows. Plan and design docs get an adaptation note recording the rig delta. * Keep agentic planning docs and roborev config out of the PR The implementation plan, design spec, and .roborev gitignore entry are contributor-side tooling artifacts, not part of the feature. Drop them from the branch so the upstream diff is code, tests, README, and example only. They remain in local history and on the backup branch. * Extract Quarto helpers into module --------- Co-authored-by: Tomasz Kalinowski <kalinowskit@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ir runto accept leadingRscriptoptions such as--vanillaand forward them to the phase-2 user-code invocation.Rscriptharness.