Preserve path when string is camelized#1987
Open
sineed wants to merge 2 commits intorails-api:masterfrom
Open
Conversation
|
@sineed, thanks for your PR! By analyzing the history of the files in this pull request, we identified @remear, @dubadub and @iancanderson to be potential reviewers. |
Member
|
So the value is being transformed? that doesn't seem right |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
In my project I have some cases when I need to make a
POSTrequest with nested data. The following data may be provided:Bid attribute may have validation errors so the response should provide this information:
But when I use camel key transformation I receive
/data/attributes/bid::Amountinstead of/data/attributes/bid/amountThis PR fixes this behavior for
camelandcamel_lowerkey transformationsChanges
In
camelandcamel_lowerkey transformationsCaveats
I saw work at #1928 and introduction of case_transform. I can make PR to this gem also.
Related GitHub issues
#1928
Additional helpful information