show focus outlines

[rubys]

Fixes #489

[patriciomacadden]

Maybe worth doing the same to the new session view?

otherwise they look different:

passwords:

new session:

the new session looks brighter because it doesn't have the focus:outline-solid class.

What I'm not sure is what looks better, if no focus:outline-solid and no outline-hidden at all or just focus:outline-solid.

what do you think?

[rubys]

Other than "they probably should be consistent", I have no opinion :-)

I'm just trying to update Agile Web Development with Rails 8, and would like to get an idea of what this will ultimately look like.

[patriciomacadden]

yep, I agree they should be consistent.

Perhaps just removing outline-hidden is one less class and makes the outline brighter, but I'm fine with either option. I'll leave this decision to you and @flavorjones .

PS: I love Agile web development with Rails! Thanks!

[flavorjones]

Thanks to you both for chatting about this! I personally like the "brighter" style of the sessions form which omits focus:outline-solid (but that may be because I'm color-blind and need to be hit over the head with affordances like this).

I'll push an update to this PR to make that change and then merge it.