Skip to content

Conversation

@VldmrVstsk
Copy link

No description provided.

@SwiftLintBot
Copy link

SwiftLintBot commented Dec 20, 2021

16 Warnings
⚠️ This PR introduced a violation in Firefox: /Client/UIScrollViewSwizzled.swift:10:13: warning: Prefixed Top-Level Constant Violation: Top-level constants should be prefixed by k. (prefixed_toplevel_constant)
⚠️ This PR introduced a violation in Firefox: /Client/UIScrollViewSwizzled.swift:11:5: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
⚠️ This PR introduced a violation in Firefox: /Client/UIScrollViewSwizzled.swift:12:5: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
⚠️ This PR introduced a violation in Firefox: /Client/UIScrollViewSwizzled.swift:13:1: warning: Line Length Violation: Line should be 120 characters or less: currently 162 characters (line_length)
⚠️ This PR introduced a violation in Firefox: /Client/UIScrollViewSwizzled.swift:13:5: warning: Conditional Returns on Newline Violation: Conditional statements should always return on the next line (conditional_returns_on_newline)
⚠️ This PR introduced a violation in Firefox: /Client/UIScrollViewSwizzled.swift:1:1: warning: File Name Violation: File name should match a type or extension declared in the file (if any). (file_name)
⚠️ This PR introduced a violation in Firefox: /Client/UIScrollViewSwizzled.swift:20:1: warning: Vertical Whitespace after Opening Braces Violation: Don't include vertical whitespace (empty line) after opening braces. (vertical_whitespace_opening_braces)
⚠️ This PR introduced a violation in Firefox: /Client/UIScrollViewSwizzled.swift:21:18: warning: Missing Docs Violation: public declarations should be documented. (missing_docs)
⚠️ This PR introduced a violation in Firefox: /Client/UIScrollViewSwizzled.swift:21:18: warning: Modifier Order Violation: public modifier should be before final. (modifier_order)
⚠️ This PR introduced a violation in Firefox: /Client/UIScrollViewSwizzled.swift:22:9: warning: Conditional Returns on Newline Violation: Conditional statements should always return on the next line (conditional_returns_on_newline)
⚠️ This PR introduced a violation in Firefox: /Client/UIScrollViewSwizzled.swift:28:11: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports. (attributes)
⚠️ This PR introduced a violation in Firefox: /Client/UIScrollViewSwizzled.swift:28:11: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Firefox: /Client/UIScrollViewSwizzled.swift:29:25: warning: Trailing Closure Violation: Trailing closure syntax should be used whenever possible. (trailing_closure)
⚠️ This PR introduced a violation in Firefox: /Client/UIScrollViewSwizzled.swift:29:9: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
⚠️ This PR introduced a violation in Firefox: /Client/UIScrollViewSwizzled.swift:30:27: warning: Trailing Closure Violation: Trailing closure syntax should be used whenever possible. (trailing_closure)
⚠️ This PR introduced a violation in Firefox: /Client/UIScrollViewSwizzled.swift:30:9: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
12 Messages
📖 Linting Aerial with this PR took 0.96s vs 0.96s on master (0% slower)
📖 Linting Alamofire with this PR took 1.0s vs 1.0s on master (0% slower)
📖 Linting Firefox with this PR took 3.32s vs 3.33s on master (0% faster)
📖 Linting Kickstarter with this PR took 6.7s vs 6.71s on master (0% faster)
📖 Linting Moya with this PR took 4.34s vs 4.37s on master (0% faster)
📖 Linting Nimble with this PR took 0.38s vs 0.38s on master (0% slower)
📖 Linting Quick with this PR took 0.18s vs 0.17s on master (5% slower)
📖 Linting Realm with this PR took 2.6s vs 2.57s on master (1% slower)
📖 Linting SourceKitten with this PR took 0.31s vs 0.3s on master (3% slower)
📖 Linting Sourcery with this PR took 1.87s vs 1.86s on master (0% slower)
📖 Linting Swift with this PR took 2.93s vs 2.93s on master (0% slower)
📖 Linting WordPress with this PR took 6.56s vs 6.57s on master (0% faster)

Generated by 🚫 Danger

@VldmrVstsk VldmrVstsk force-pushed the improvements/function_body_length branch from 0e18f02 to cda217a Compare December 21, 2021 11:59
@VldmrVstsk VldmrVstsk force-pushed the improvements/function_body_length branch from cda217a to 7ae4dbd Compare December 21, 2021 12:36
@VldmrVstsk VldmrVstsk marked this pull request as draft December 22, 2021 11:38
@jpsim
Copy link
Collaborator

jpsim commented Jan 21, 2022

Let me know when you'd like this reviewed @VldmrVstsk !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants