-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Ignore comments starting right at the beginning of a line #4198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SimplyDanny
wants to merge
1
commit into
realm:main
Choose a base branch
from
SimplyDanny:ignore-comment-in-indentation-width-rule
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ignore comments starting right at the beginning of a line #4198
SimplyDanny
wants to merge
1
commit into
realm:main
from
SimplyDanny:ignore-comment-in-indentation-width-rule
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e242ca1 to
dd08984
Compare
dd08984 to
d93984f
Compare
Collaborator
Author
|
The reported violations are not new. They must have already been there before the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might fix #3430. The comments used by Xcode only use
//so there might not be the need to support block comments too. I think they are mainly what caused the issue. Thus, simply ignoring lines starting with//should be enough?