Skip to content

Conversation

@alwold
Copy link

@alwold alwold commented Apr 21, 2023

This adds an opt-in rule to enforce alphabetical order on properties/methods in a type. The order can be enforced on "groups" of members, or on all members in the type.

This is my first rule, so feel free to rip it apart if I should do anything differently :)

alwold added 2 commits April 21, 2023 16:03
This enforces alphabetical order on properties/methods in a type.
@SwiftLintBot
Copy link

SwiftLintBot commented Apr 21, 2023

43271 Warnings
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:119:10: warning: Type Member Order Violation: show(sender:controller:) should be before windowWillClose(_:) (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:17:19: warning: Type Member Order Violation: addFolderCatalinaPanel should be before mainPanel (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:23:19: warning: Type Member Order Violation: folderView should be before topPathControl (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:24:19: warning: Type Member Order Violation: fileView should be before folderView (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:260:20: warning: Type Member Order Violation: timePopUpChange(:) should be before videoNameChange(:) (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:27:19: warning: Type Member Order Violation: folderShortNameTextField should be before onboardingLabel (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:283:20: warning: Type Member Order Violation: addPoiValidate(:) should be before removePoiClick(:) (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:29:19: warning: Type Member Order Violation: editPlayerView should be before timePopUpButton (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:32:19: warning: Type Member Order Violation: poiTableView should be before videoNameTextField (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:33:19: warning: Type Member Order Violation: addPoi should be before poiTableView (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:36:19: warning: Type Member Order Violation: addPoiPopover should be before removePoi (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:39:19: warning: Type Member Order Violation: timeTextFormatter should be before timeTextStepper (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:40:19: warning: Type Member Order Violation: descriptionTextField should be before timeTextFormatter (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:44:19: warning: Type Member Order Violation: cvcMenu should be before resolutionLabel (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:48:9: warning: Type Member Order Violation: currentFolder should be before menuRemoveVideo (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:49:9: warning: Type Member Order Violation: currentAsset should be before currentFolder (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:54:9: warning: Type Member Order Violation: controller should be before sw (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/Forecast.swift:103:9: warning: Type Member Order Violation: deg should be before speed (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/Forecast.swift:18:18: warning: Type Member Order Violation: cnt should be before message (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/Forecast.swift:20:9: warning: Type Member Order Violation: city should be before list (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/Forecast.swift:27:9: warning: Type Member Order Violation: coord should be before name (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/Forecast.swift:29:31: warning: Type Member Order Violation: sunrise should be before timezone (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/Forecast.swift:42:9: warning: Type Member Order Violation: clouds should be before weather (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/Forecast.swift:44:9: warning: Type Member Order Violation: visibility should be before wind (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/Forecast.swift:45:9: warning: Type Member Order Violation: pop should be before visibility (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/Forecast.swift:47:9: warning: Type Member Order Violation: dtTxt should be before sys (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/Forecast.swift:64:15: warning: Type Member Order Violation: feelsLike should be before temp (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/Forecast.swift:64:35: warning: Type Member Order Violation: tempMax should be before tempMin (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/Forecast.swift:65:29: warning: Type Member Order Violation: grndLevel should be before seaLevel (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/Forecast.swift:65:9: warning: Type Member Order Violation: pressure should be before tempMax (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/GeoCoding.swift:14:9: warning: Type Member Order Violation: lat should be before name (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/GeoCoding.swift:15:9: warning: Type Member Order Violation: country should be before lon (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:102:9: warning: Type Member Order Violation: feelsLike should be before temp (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:103:19: warning: Type Member Order Violation: humidity should be before pressure (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:104:9: warning: Type Member Order Violation: dewPoint should be before humidity (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:105:9: warning: Type Member Order Violation: windDeg should be before windSpeed (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:106:9: warning: Type Member Order Violation: weather should be before windDeg (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:107:9: warning: Type Member Order Violation: clouds should be before weather (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:108:19: warning: Type Member Order Violation: rain should be before uvi (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:123:21: warning: Type Member Order Violation: eve should be before night (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:128:19: warning: Type Member Order Violation: max should be before min (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:129:9: warning: Type Member Order Violation: eve should be before night (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:20:9: warning: Type Member Order Violation: current should be before timezoneOffset (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:22:9: warning: Type Member Order Violation: hourly should be before minutely (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:23:9: warning: Type Member Order Violation: daily should be before hourly (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:51:15: warning: Type Member Order Violation: feelsLike should be before temp (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:52:19: warning: Type Member Order Violation: humidity should be before pressure (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:53:9: warning: Type Member Order Violation: dewPoint should be before humidity (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:54:9: warning: Type Member Order Violation: clouds should be before uvi (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:56:9: warning: Type Member Order Violation: windDeg should be before windSpeed (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:57:9: warning: Type Member Order Violation: weather should be before windDeg (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:58:19: warning: Type Member Order Violation: pop should be before windGust (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:26:9: warning: Type Member Order Violation: base should be before weather (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:30:9: warning: Type Member Order Violation: clouds should be before wind (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:33:19: warning: Type Member Order Violation: id should be before timezone (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:35:9: warning: Type Member Order Violation: cod should be before name (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:60:14: warning: Type Member Order Violation: lat should be before lon (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:65:9: warning: Type Member Order Violation: feelsLike should be before temp (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:66:18: warning: Type Member Order Violation: tempMax should be before tempMin (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:66:27: warning: Type Member Order Violation: pressure should be before tempMax (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:66:37: warning: Type Member Order Violation: humidity should be before pressure (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:79:15: warning: Type Member Order Violation: id should be before type (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:80:9: warning: Type Member Order Violation: country should be before id (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:87:35: warning: Type Member Order Violation: icon should be before weatherDescription (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:99:9: warning: Type Member Order Violation: deg should be before speed (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:153:10: warning: Type Member Order Violation: getMiniSymbol(:tint:) should be before getSymbol(:) (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:177:10: warning: Type Member Order Violation: getAccentedSymbol(_:) should be before resize(image:w:h:) (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:188:18: warning: Type Member Order Violation: fallbackSymbol(:) should be before getAccentedSymbol(:) (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:19:9: warning: Type Member Order Violation: appMode should be before windowController (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:350:10: warning: Type Member Order Violation: maybeMuteSound() should be before migratePreferences() (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/AerialVideo.swift:203:10: warning: Type Member Order Violation: hasHDR() should be before updateDuration() (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/AerialVideo.swift:249:18: warning: Type Member Order Violation: getBestFormat() should be before getCurrentFormat() (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/AerialVideo.swift:25:9: warning: Type Member Order Violation: timeOfDay should be before type (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/AerialVideo.swift:26:9: warning: Type Member Order Violation: scene should be before timeOfDay (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/AerialVideo.swift:30:9: warning: Type Member Order Violation: source should be before urls (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/AerialVideo.swift:32:9: warning: Type Member Order Violation: poi should be before source (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/AerialVideo.swift:33:9: warning: Type Member Order Violation: communityPoi should be before poi (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/AerialVideo.swift:36:9: warning: Type Member Order Violation: arrayPosition should be before duration (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/AerialVideo.swift:42:9: warning: Type Member Order Violation: isAvailableOffline should be before isVertical (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/AssetLoaderDelegate.swift:28:9: warning: Type Member Order Violation: videoCache should be before videoLoaders (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/AssetLoaderDelegate.swift:30:9: warning: Type Member Order Violation: URLWithCustomScheme should be before videoCache (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/AssetLoaderDelegate.swift:51:10: warning: Type Member Order Violation: videoLoader(:receivedData:forRange:) should be before videoLoader(:receivedResponse:) (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:42:16: warning: Type Member Order Violation: processedSupportPath should be before ssid (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:510:17: warning: Type Member Order Violation: hasSomeFreeSpace() should be before isFull() (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:646:17: warning: Type Member Order Violation: canNetwork() should be before ensureDownload(action:) (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:101:18: warning: Type Member Order Violation: ensureLoadedBundle() should be before loadBundle() (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:245:10: warning: Type Member Order Violation: getCommunityName(id:) should be before loadCommunity() (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:31:9: warning: Type Member Order Violation: communityStrings should be before stringDict (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:32:9: warning: Type Member Order Violation: communityLanguage should be before communityStrings (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Thumbnails.swift:165:25: warning: Type Member Order Violation: getLargePath(forVideo:) should be before getPath(forVideo:) (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Thumbnails.swift:169:17: warning: Type Member Order Violation: get(forVideo:_:) should be before getLargePath(forVideo:) (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoCache.swift:15:9: warning: Type Member Order Violation: mutableVideoData should be before videoData (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoCache.swift:16:9: warning: Type Member Order Violation: loading should be before mutableVideoData (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoCache.swift:17:9: warning: Type Member Order Violation: loadedRanges should be before loading (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoCache.swift:18:9: warning: Type Member Order Violation: URL should be before loadedRanges (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoCache.swift:21:16: warning: Type Member Order Violation: computedAppSupportDirectory should be before computedCacheDirectory (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:194:10: warning: Type Member Order Violation: failedDownload(_:) should be before finishedDownload() (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:22:9: warning: Type Member Order Violation: contentInformationRequest should be before response (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:274:10: warning: Type Member Order Violation: connection(:didFailWithError:) should be before connectionDidFinishLoading(:) (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:35:14: warning: Type Member Order Violation: delegate should be before streams (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:41:9: warning: Type Member Order Violation: data should be before video (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:43:9: warning: Type Member Order Violation: contentLength should be before downloadedData (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:64:10: warning: Type Member Order Violation: cancel() should be before startDownloadForContentInformation() (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoLoader.swift:14:10: warning: Type Member Order Violation: videoLoader(:receivedData:forRange:) should be before videoLoader(:receivedResponse:) (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoLoader.swift:20:14: warning: Type Member Order Violation: delegate should be before response (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoLoader.swift:24:9: warning: Type Member Order Violation: loadedRange should be before loadingRequest (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoLoader.swift:26:9: warning: Type Member Order Violation: loadRange should be before requestedRange (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoManager.swift:141:10: warning: Type Member Order Violation: cancelAll() should be before updateProgress(id:progress:) (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoManager.swift:149:9: warning: Type Member Order Violation: download should be before video (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoManager.swift:19:17: warning: Type Member Order Violation: checkCells should be before progressCallbacks (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoManager.swift:25:21: warning: Type Member Order Violation: operations should be before queuedVideos (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoManager.swift:29:9: warning: Type Member Order Violation: stopAll should be before totalQueued (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoManager.swift:34:17: warning: Type Member Order Violation: queue should be before stopAll (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoManager.swift:48:10: warning: Type Member Order Violation: addCallback(_:) should be before addCheckCellView(id:checkCellView:) (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoManager.swift:63:10: warning: Type Member Order Violation: isVideoQueued(id:) should be before updateAllCheckCellView() (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoManager.swift:95:10: warning: Type Member Order Violation: finishedDownload(id:success:) should be before queueDownload(_:) (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/CustomVideoFolders+helpers.swift:32:10: warning: Type Member Order Violation: getFolder(withUrl:) should be before getFolderIndex(withUrl:) (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/CustomVideoFolders.swift:107:10: warning: Type Member Order Violation: jsonData() should be before with(url:label:assets:) (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/CustomVideoFolders.swift:120:9: warning: Type Member Order Violation: accessibilityLabel should be before url (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/CustomVideoFolders.swift:176:10: warning: Type Member Order Violation: jsonData() should be before with(pointsOfInterest:url:accessibilityLabel:id:time:) (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/CustomVideoFolders.swift:48:10: warning: Type Member Order Violation: jsonData() should be before with(folders:) (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/CustomVideoFolders.swift:60:9: warning: Type Member Order Violation: label should be before url (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/CustomVideoFolders.swift:61:9: warning: Type Member Order Violation: assets should be before label (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Downloads/AsynchronousOperation.swift:41:17: warning: Type Member Order Violation: rawState should be before stateQueue (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Downloads/AsynchronousOperation.swift:53:31: warning: Type Member Order Violation: isExecuting should be before isReady (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Downloads/AsynchronousOperation.swift:82:24: warning: Type Member Order Violation: main() should be before start() (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Downloads/AsynchronousOperation.swift:88:23: warning: Type Member Order Violation: finish() should be before main() (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Downloads/DownloadManager.swift:102:9: warning: Type Member Order Violation: folder should be before task (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Downloads/DownloadManager.swift:51:10: warning: Type Member Order Violation: cancelAll() should be before queueDownload(_:folder:) (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/ErrorLog.swift:183:6: warning: Type Member Order Violation: debugLog(:) should be before logToDisk(:) (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/ErrorLog.swift:198:6: warning: Type Member Order Violation: errorLog(:) should be before warnLog(:) (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/ErrorLog.swift:20:9: warning: Type Member Order Violation: actionName should be before message (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/ErrorLog.swift:21:9: warning: Type Member Order Violation: actionBlock should be before actionName (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Hardware/Battery.swift:38:17: warning: Type Member Order Violation: getRemainingPercent() should be before isLow() (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Hardware/DisplayDetection.swift:15:9: warning: Type Member Order Violation: height should be before width (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Hardware/DisplayDetection.swift:16:9: warning: Type Member Order Violation: bottomLeftFrame should be before height (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Hardware/DisplayDetection.swift:19:9: warning: Type Member Order Violation: isMain should be before zeroedOrigin (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Hardware/DisplayDetection.swift:20:9: warning: Type Member Order Violation: backingScaleFactor should be before isMain (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Hardware/DisplayDetection.swift:224:10: warning: Type Member Order Violation: belowMargin() should be before leftMargin() (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Hardware/DisplayDetection.swift:419:10: warning: Type Member Order Violation: findDisplayAdvancedMargins(posx:posy:) should be before getMarginsJSON() (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Hardware/DisplayDetection.swift:45:9: warning: Type Member Order Violation: cmInPoints should be before screens (type_member_order)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Hardware/DisplayDetection.swift:468:9: warning: Type Member Order Violation: offsetleft should be before ztop (type_member_order)
⚠️ Danger found 43271 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 142.
68 Messages
📖 Linting Aerial with this PR took 1.09s vs 1.06s on main (2% slower)
📖 Linting Alamofire with this PR took 1.37s vs 1.36s on main (0% slower)
📖 Linting Brave with this PR took 7.17s vs 7.16s on main (0% slower)
📖 Linting DuckDuckGo with this PR took 3.53s vs 3.51s on main (0% slower)
📖 Linting Firefox with this PR took 9.02s vs 9.09s on main (0% faster)
📖 Linting Kickstarter with this PR took 9.94s vs 9.87s on main (0% slower)
📖 Linting Moya with this PR took 0.55s vs 0.57s on main (3% faster)
📖 Linting NetNewsWire with this PR took 3.05s vs 3.03s on main (0% slower)
📖 Linting Nimble with this PR took 0.63s vs 0.63s on main (0% slower)
📖 Linting PocketCasts with this PR took 7.15s vs 7.12s on main (0% slower)
📖 Linting Quick with this PR took 0.24s vs 0.24s on main (0% slower)
📖 Linting Realm with this PR took 10.96s vs 10.96s on main (0% slower)
📖 Linting SourceKitten with this PR took 0.39s vs 0.39s on main (0% slower)
📖 Linting Sourcery with this PR took 2.21s vs 2.19s on main (0% slower)
📖 Linting Swift with this PR took 4.63s vs 4.61s on main (0% slower)
📖 Linting VLC with this PR took 1.34s vs 1.34s on main (0% slower)
📖 Linting Wire with this PR took 8.11s vs 8.1s on main (0% slower)
📖 Linting WordPress with this PR took 11.26s vs 11.19s on main (0% slower)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:11:1: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly (explicit_acl)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:11:1: warning: Explicit Top Level ACL Violation: Top-level declarations should specify Access Control Level keywords explicitly (explicit_top_level_acl)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:11:1: warning: Required Deinit Violation: Classes should have an explicit deinit method (required_deinit)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:12:1: warning: Vertical Whitespace after Opening Braces Violation: Don't include vertical whitespace (empty line) after opening braces (vertical_whitespace_opening_braces)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:15:5: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly (explicit_acl)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:16:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:16:48: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:17:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:18:9: warning: Prefer Nimble Violation: Prefer Nimble matchers over XCTAssert functions (prefer_nimble)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:18:9: warning: XCTest Specific Matcher Violation: Prefer the specific matcher 'XCTAssertEqual' instead (xct_specific_matcher)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:21:5: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly (explicit_acl)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:22:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:23:53: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:25:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:26:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:32:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:34:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:35:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:41:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:42:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:48:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:49:105: warning: Force Unwrapping Violation: Force unwrapping should be avoided (force_unwrapping)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:49:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:50:27: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line (multiline_arguments_brackets)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:50:59: warning: Multiline Arguments Violation: Arguments should be either on the same line, or one per line (multiline_arguments)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:51:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces (indentation_width)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:51:56: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line (multiline_arguments_brackets)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:56:5: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly (explicit_acl)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:57:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:58:53: warning: Legacy Objective-C Reference Type Violation: Prefer Swift value types to bridged Objective-C reference types (legacy_objc_type)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:5:1: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly (explicit_acl)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:5:1: warning: Explicit Top Level ACL Violation: Top-level declarations should specify Access Control Level keywords explicitly (explicit_top_level_acl)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:5:5: warning: Prefixed Top-Level Constant Violation: Top-level constants should be prefixed by k (prefixed_toplevel_constant)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:60:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:61:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:67:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:69:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:6:1: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly (explicit_acl)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:6:1: warning: Explicit Top Level ACL Violation: Top-level declarations should specify Access Control Level keywords explicitly (explicit_top_level_acl)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:6:5: warning: Prefixed Top-Level Constant Violation: Top-level constants should be prefixed by k (prefixed_toplevel_constant)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:70:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:76:103: warning: Force Unwrapping Violation: Force unwrapping should be avoided (force_unwrapping)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:76:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:77:27: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line (multiline_arguments_brackets)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:77:62: warning: Multiline Arguments Violation: Arguments should be either on the same line, or one per line (multiline_arguments)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:78:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces (indentation_width)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:78:56: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line (multiline_arguments_brackets)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:81:5: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly (explicit_acl)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:92:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in SourceKitten: /Tests/SourceKittenFrameworkTests/ModuleTests.swift:93:9: warning: Prefer Nimble Violation: Prefer Nimble matchers over XCTAssert functions (prefer_nimble)

Generated by 🚫 Danger

- Shorten some of the lines in the rule
- Turn off the new rule on the main .swiftlint.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants