This repository was archived by the owner on Sep 3, 2025. It is now read-only.
Add ARC verification #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmotylev
reviewed
Nov 28, 2022
Contributor
dmotylev
left a comment
There was a problem hiding this comment.
There are a couple of suggestions regarding naming, which might add some clarity w/o much documenting
Co-authored-by: Dmitry Motylev <[email protected]>
Co-authored-by: Dmitry Motylev <[email protected]>
0c9c163 to
c34228c
Compare
jpicht
reviewed
Dec 5, 2022
jpicht
left a comment
There was a problem hiding this comment.
A few minor things, looks good otherwise.
arc.go
Outdated
| amsKey = "ARC-Message-signature" | ||
| aarKey = "ARC-Authentication-Results" | ||
|
|
||
| errMissingArcFields = errors.New("missing arc fields") |
| } | ||
| // if "c=" not given, use relaxed | ||
| if !ams.canonicalization { | ||
| ams.RelaxedHeader = true |
Contributor
There was a problem hiding this comment.
On as, yes. The ams is the result of parseSignature(...)
Contributor
Author
There was a problem hiding this comment.
Yea on AS, on the AMS header sometimes the cannonization field is not provided, so we just want a default here.
arc_test.go
Outdated
|
|
||
| for testName, test := range doc.Tests { | ||
| t.Run(fmt.Sprintf("%s", testName), func(t *testing.T) { | ||
| //if testName != "ams_fields_c_sr" { |
dkim.go
Outdated
| // Only used for arc, so only contains the used result codes | ||
| // https://www.rfc-editor.org/rfc/rfc8617.html#section-4.4 | ||
| func extractResultCode(value string) ResultCode { | ||
| //todo: check if we need this bit |
Contributor
Author
There was a problem hiding this comment.
Was an old comment, removed
c223a0f to
aa8f3a7
Compare
470ed66 to
c4cccf1
Compare
jpicht
approved these changes
Dec 14, 2022
dmotylev
reviewed
Jan 4, 2023
jpicht
approved these changes
Jan 9, 2023
dmotylev
approved these changes
Jan 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rfc-editor.org/rfc/rfc8617.html