Remove LiveReload, enable action-test
#11416
Conversation
|
| "test:integration": "pnpm playwright:integration", | ||
| "posttest:integration": "pnpm clean:integration", | ||
| "playwright:integration": "playwright test --config ./integration/playwright.config.ts --project chromium", | ||
| "playwright:integration": "playwright test --config ./integration/playwright.config.ts --project=chromium", |
There was a problem hiding this comment.
I changed this so that I can pass a test name, otherwise it treats it as another project name.
|
🤖 Hello there, We just published version Thanks! |
action-testwas failing because of the use ofLiveReload.LiveReloadwas causing errors becausereact-router-dom/serverwasn't in Vite'soptimizeDeps.includelist, whereas@remix-run/reactwas. This meant that the Vite detection logic didn't work (let isViteClient = import.meta && import.meta.env !== undefined) so rather than renderingnullit was falling through to the old logic that assumes the use of the classic compiler.Since the
LiveReloadcomponent is now dead code because we're only using Vite, I'm opting to remove it entirely rather than re-introducingreact-router-dom/servertooptimizeDeps.include, cc @brophdawg11.