Skip to content

Conversation

@mikehardy
Copy link
Contributor

Just tracking upstream.

Note that with an API 25 and API 26 emulator running, I am not able to run connectedCheck successfully, but this is not new to this PR. It just bears mentioning as I am unsure how to verify the correctness of the work here:

mike@isabela:~/work/sqlite-android (upstream-3.25.3 *) % ./gradlew connectedCheck
Download http://sqlite.org/2018/sqlite-amalgamation-3250300.zip

> Task :sqlite-android:externalNativeBuildDebug
Build sqlite3x x86
make: `/home/mike/work/sqlite-android/sqlite-android/build/intermediates/ndkBuild/debug/obj/local/x86/libsqlite3x.so' is up to date.
Build sqlite3x arm64-v8a
make: `/home/mike/work/sqlite-android/sqlite-android/build/intermediates/ndkBuild/debug/obj/local/arm64-v8a/libsqlite3x.so' is up to date.
Build sqlite3x x86_64
make: `/home/mike/work/sqlite-android/sqlite-android/build/intermediates/ndkBuild/debug/obj/local/x86_64/libsqlite3x.so' is up to date.
Build sqlite3x armeabi-v7a
make: `/home/mike/work/sqlite-android/sqlite-android/build/intermediates/ndkBuild/debug/obj/local/armeabi-v7a/libsqlite3x.so' is up to date.
Starting 50 tests on Pixel_API_26_NEW(AVD) - 8.0.0
Starting 50 tests on Pixel_API_25_NEW(AVD) - 7.1.1

io.requery.android.database.NewDatabasePerformanceTestSuite > null[Pixel_API_25_NEW(AVD) - 7.1.1] SKIPPED 

io.requery.android.database.NewDatabasePerformanceTestSuite > null[Pixel_API_26_NEW(AVD) - 8.0.0] SKIPPED 

io.requery.android.database.benchmark.Benchmark > runBenchmark[Pixel_API_25_NEW(AVD) - 7.1.1] FAILED 
        android.database.CursorWindowAllocationException: Cursor window allocation of 2048 kb failed.
        at android.database.CursorWindow.<init>(CursorWindow.java:108)

> Task :sqlite-android:connectedDebugAndroidTest FAILED

@npurushe npurushe merged commit b8a4bd2 into requery:master Nov 9, 2018
@mikehardy
Copy link
Contributor Author

Thanks @npurushe - we support API15+ with about a million users in our open source project and almost all our crashes are native sqlite things that are fixed upstream, so I appreciate the work on requery letting us get the fixes out 🍺

@mikehardy mikehardy deleted the upstream-3.25.3 branch November 9, 2018 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants