Skip to content

RzCore: read core block before printing#2694

Merged
ret2libc merged 3 commits into
devfrom
debug-pd-block
Jun 14, 2022
Merged

RzCore: read core block before printing#2694
ret2libc merged 3 commits into
devfrom
debug-pd-block

Conversation

@ret2libc

Copy link
Copy Markdown
Member

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

With the new pd conversion to newshell, it seems that those commands directly use core->block, which when setting hardware breakpoints (possibly also in other cases) might be outdated. In general, I think we should try to remove core->block as much as possible and maybe use an internal(transparent) cache within RzCore/RzIo.

Test plan

See issue.

Closing issues

Closes #2692

@ret2libc ret2libc enabled auto-merge (squash) June 14, 2022 15:03
@ret2libc ret2libc merged commit 5e43ea2 into dev Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Debugger disassembly problem after "continue"

2 participants