Removed copy toast, replaced it with animation on the copy icon. #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icon showing that the field has been copied.
ortex
reviewed
Feb 8, 2023
| Handler().postDelayed({ | ||
| animateImageChange(context, icon, R.drawable.ic_copy) | ||
| }, 1250) | ||
| /*val myToast = Toast.makeText(context, "Copied!", Toast.LENGTH_SHORT) |
Member
|
LGTM! @valeryhime Could you have a look, please? |
valeryhime
reviewed
Feb 8, 2023
|
|
||
| view.findViewById<ConstraintLayout>(R.id.copy_block).setOnClickListener { | ||
| setClipboard(context, findViewById<TextView>(R.id.block_label).text.toString()) | ||
| setClipboard(context, findViewById<TextView>(R.id.block_label).text.toString(), it.findViewById<ImageView>(R.id.copy_icon)) |
Contributor
There was a problem hiding this comment.
It seems now we need entire copyblock component in this method, and the call looks too long =) Maybe it'll be better just to send "it" here and get icon and text inside the setClipboard?
setClipboard(context, it)
Member
There was a problem hiding this comment.
it is possible to reuse textBlock here?
setClipboard(context, textBlock.text, it.findViewById(R.id.copy_icon))and change setClipboard signature to private fun setClipboard(context: Context, text: CharSequence, icon: ImageView)
valeryhime
reviewed
Feb 8, 2023
| animateImageChange(context, icon, R.drawable.ic_done) | ||
| Handler().postDelayed({ | ||
| animateImageChange(context, icon, R.drawable.ic_copy) | ||
| }, 1250) |
Contributor
There was a problem hiding this comment.
How do you feel about making it a bit faster? Maybe 1000?
Contributor
|
Looks good 👍 Thank you ^_^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change resolving #50 by removing toast and replacing it with an animation on the copy icon to show that the field has been copied.
Possible alternative could be checking android version to see if it's 12 or higher and displaying the toast depending on that. Decided against it because the "copied to clipboard" OS Toast can be disabled in settings by user.
App cannot disable OS Toast due to it being OS level and automatic.