Skip to content

Sign release APK #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ortex merged 1 commit into from
May 14, 2023
Merged

Sign release APK #70

ortex merged 1 commit into from
May 14, 2023

Conversation

@gavv
Copy link
Member

@gavv gavv commented May 14, 2023 •
edited
Loading

Fixes #39.

Changes:

  • Add signingConfig to gradle (enabled if corresponding env vars are set)
  • Export signing secrets when building release APK on CI
  • Document process in README

Secrets are already added to the repo.

@gavv gavv requested a review from ortex May 14, 2023 18:57
@gavv gavv mentioned this pull request May 14, 2023
Closed
@ortex ortex merged commit 829d6e6 into roc-streaming:main May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ortex ortex ortex approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Publish release version of APK on github

2 participants

@gavv @ortex