Skip to content

Conversation

@JamesOsborn-SE
Copy link
Contributor

@JamesOsborn-SE
Copy link
Contributor Author

This won't affect the f-droid app until the next tag/release.

@ortex
Copy link
Member

ortex commented Apr 29, 2024

Thanks!

Shouldn't we put metadata to fastline dir?

I'm not sure. Only have a quick look at https://f-droid.org/en/docs/All_About_Descriptions_Graphics_and_Screenshots/#fastlane-structure

@JamesOsborn-SE
Copy link
Contributor Author

Thanks!

Shouldn't we put metadata to fastline dir?

I'm not sure. Only have a quick look at https://f-droid.org/en/docs/All_About_Descriptions_Graphics_and_Screenshots/#fastlane-structure

We could, but metadata is proper too:

quote from the page(emphasis mine) :
This structure must be placed at one of the following locations from the repository’s root:

  • metadata/
  • fastlane/metadata/android/

It's where I keep it for my app, and it works just fine

my app in the f-droid store:
https://f-droid.org/en/packages/dev.develsinthedetails.eatpoopyoucat/
source code:
https://github.com/JamesOsborn-SE/eat-poop-you-cat-android

@JamesOsborn-SE
Copy link
Contributor Author

JamesOsborn-SE commented Apr 30, 2024

I think they are waiting for a release with the metadata… I don't think it's strictly necessary, but I don't think there's a need to be in a hurry either.
https://gitlab.com/fdroid/fdroiddata/-/merge_requests/14910

@licaon-kter
Copy link

https://gitlab.com/-/snippets/1895688#locations

I don't think it's strictly necessary, but I don't think there's a need to be in a hurry either.

the MR waits for this merge, right?

@ortex ortex merged commit 8923fc5 into roc-streaming:main Apr 30, 2024
@ortex
Copy link
Member

ortex commented Apr 30, 2024

This won't affect the f-droid app until the next tag/release.

Do we need to make a new tag/release?

@licaon-kter
Copy link

no @ortex as this only touches metadata and not code

@JamesOsborn-SE
Copy link
Contributor Author

JamesOsborn-SE commented Apr 30, 2024

no @ortex as this only touches metadata and not code

Thanks for the clarification. I think once the release is processed and on the store, you need a new release if you update the metadata. Is that right?

@licaon-kter
Copy link

Yes, afaik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants