Update sage 9.x dependencies

[strarsis]

This PR updates the dependencies of sage 9.x as far as possible without breaking the build process.

All dependencies have been updated as much as possible without breaking the build process or introducing too many configuration changes.

Related PR: #2569

[atoupet-toki]

Thanks for your good job! Seems that there is some warning during install :)

warning " > [email protected]" has incorrect peer dependency "popper.js@^1.16.1". warning " > [email protected]" has unmet peer dependency "postcss@^8.1.0". warning " > [email protected]" has incorrect peer dependency "eslint@^6.0.0 || ^7.0.0". warning " > [email protected]" has incorrect peer dependency "webpack@^4.0.0 || ^5.0.0". warning " > [email protected]" has incorrect peer dependency "webpack@^4.0.0 || ^5.0.0". warning " > [email protected]" has incorrect peer dependency "webpack@^4.0.0 || ^5.0.0". warning " > [email protected]" has unmet peer dependency "postcss@^7.0.0 || ^8.0.1". warning " > [email protected]" has incorrect peer dependency "node-sass@^4.0.0". warning " > [email protected]" has incorrect peer dependency "stylelint@^8.0.0". warning " > [email protected]" has incorrect peer dependency "webpack@^1.13.2 || ^2.7.0 || ^3.11.0 || ^4.4.0". warning " > [email protected]" has incorrect peer dependency "webpack@^4.0.0 || ^5.0.0".

[strarsis]

@atoupet-toki: During install indeed some warnings appear. But I can't find the bootstrap one (and I selected bootstrap as framework). Have you installed the latest sage 9.x?

[atoupet-toki]

@strarsis I just tried once again. I dont know if there were some cache but I got a few warnings but no bootstrap on my side too! :)

[jkananen]

I did a similar effort last week based on 9.0.9 and noticed that the following versions needs to be in place for background-image('../images/svg/file.svg'); to work:

-    "file-loader": "^6.2.0",
+    "file-loader": "^1.1.6",

-    "resolve-url-loader": "^3.1.2",
+    "resolve-url-loader": "~2.3.1",

I am today merging an old Sage 8 theme to 9.0.10 and am seeing the same as last week:

Module not found: Error: Can't resolve...

Assets compile with the aforementioned changed package versions. What I am working on now is far from being ready so I can't say anything about how things actually look.

Apologies if I'm mistaken, but that's what I'll have to stick to for the time being.

[ecruhling]

i can confirm that having file-loader and resolve-url-loader at the higher versions in this commit (6.2.0 & 3.1.2 respectively) breaks the build process if you have any image files referenced in the CSS. it was breaking specifically for me in slick.js pulling in a background image reverting file-loader and resolve-url-loader to previous versions and the build process works again

…

On Nov 11, 2020, at 8:15 AM, jokanane ***@***.***> wrote: I did a similar effort last week based on 9.0.9 and noticed that the following versions needs to be in place for background-image('../images/svg/file.svg'); to work: - "file-loader": "^6.2.0", + "file-loader": "^1.1.6", - "resolve-url-loader": "^3.1.2", + "resolve-url-loader": "~2.3.1", I am today merging an old Sage 8 theme to 9.0.10 and am seeing the same as last week: Module not found: Error: Can't resolve... Assets compile with the aforementioned changed package versions. What I am working on now is far from being ready so I can't say anything about how things actually look. Apologies if I'm mistaken, but that's what I'll have to stick to for the time being. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2572 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA7P2J5MIUKQD5REFM2BN6LSPKMBRANCNFSM4TIBNM6A>.

[atoupet-toki]

Same happens here. After some research, we need the latests versions of nodeJS for the new dependencies ...

[strarsis]

@atoupet-toki: You can use a node version manager like nvm and just let it install the latest LTS version:
nvm install lts/*
nvm use lts/*
You can even add a .nvmrc file to the theme folder to lock in a specific node version (not just lts/*),
so everyone that uses that project will use the same node version on which the build is known to work.

[atoupet-toki]

@strarsis Thank you I used once nvm but never heard from .nvmrc files. I'll take a look at the whole thing thanks for the info!

[strarsis]

@atoupet-toki: Besides the usefulness of nvm for reproducible builds (among sytems and team members),
there seems to be an issue that crops up caused by one of the updated dependency, I am looking into that.

[strarsis]

PR for fixes in sage 9: #2603

[strarsis]

https://discourse.roots.io/t/sage-9-2-please-test/20067/9