Improve primary_navigation menu location #2814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The contents of the menu were being conditionally displayed, but it would display an empty `<nav>` element if the menu location wasn’t set.
QWp6t
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the
primary_navigationmenu location in two ways. First, the<nav>element is no longer displayed if nothing is set the menu location. Previously, the contents of the element were conditionally displayed. There’s no point in displaying the element if it’s empty. Second, this menu location now uses the menu name set by the user as the accessible name of the<nav>element. I am usingaria-labelrather thanaria-labelledby(with a hidden element as the label) since the prior issues with translatingaria-labelin Chrome have been resolved.