Skip to content

fix(bundle-editor): remove @wordpress/edit-post #2932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
retlehs merged 1 commit into from
Jan 14, 2022
Merged

fix(bundle-editor): remove @wordpress/edit-post #2932

retlehs merged 1 commit into from
Jan 14, 2022

Conversation

@retlehs
Copy link
Member

@retlehs retlehs commented Jan 5, 2022

closes #2919

@retlehs retlehs added build javascript Pull requests that update Javascript code labels Jan 5, 2022
@retlehs retlehs added this to the 10.0.0-beta.3 milestone Jan 5, 2022
@retlehs retlehs requested a review from kellymears January 5, 2022 04:49
@retlehs retlehs self-assigned this Jan 5, 2022
@github-actions github-actions bot removed the build label Jan 5, 2022
@kellymears
Copy link
Contributor

kellymears commented Jan 5, 2022

there are 17,775 issue results for @wordpress/edit-post in the gutenberg repo. https://github.com/WordPress/gutenberg/search?q=%40wordpress%2Fedit-post+is%3Aissue&type=issues

When I first wrote this it was a requirement in order to load registerBlockStyle and unregisterBlockStyle. Almost impossible to review if that is no longer the case.

I'll check and make sure this doesn't break that and what workarounds we might have if it does.

@kellymears
Copy link
Contributor

kellymears commented Jan 5, 2022

Related issue: WordPress/gutenberg#9757

May have been fixed for us in: WordPress/gutenberg#34299

@retlehs
Copy link
Member Author

retlehs commented Jan 10, 2022

@kellymears registerBlockStyle and unregisterBlockStyle are both working as expected with this PR, is there any reason why this can't be merged?

tbh i'm not super interested in waiting on gutenberg fixes to work their way into wp core if we can merge and fix this now

@kellymears
Copy link
Contributor

kellymears commented Jan 12, 2022

no, its good to merge!

@retlehs retlehs merged commit ea4da9c into main Jan 14, 2022
@retlehs retlehs deleted the editor-remove-edit-post branch January 14, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kellymears kellymears kellymears approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@retlehs retlehs

Labels

javascript Pull requests that update Javascript code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: Fatal error on wp-admin widgets

3 participants

@retlehs @kellymears