Skip to content

Conversation

@knowler
Copy link
Member

@knowler knowler commented Jan 5, 2022

I just noticed at some point during the big Sage 10 PR app/setup.php became executable. I have no clue if this matters, but I figure we should just restore it to not be executable.

@github-actions github-actions bot added the php Pull requests that update PHP code label Jan 5, 2022
@knowler knowler requested a review from retlehs January 5, 2022 06:53
Copy link
Member

@retlehs retlehs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 🙏

@knowler knowler merged commit 7b427c4 into main Jan 5, 2022
@knowler knowler deleted the fix-setup-file-permissions branch January 5, 2022 07:06
@retlehs retlehs added this to the 10.0.0-beta.3 milestone Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

php Pull requests that update PHP code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants