Skip to content

fix(views): Use dot notation on entry-meta view includes #2941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Log1x merged 1 commit into from
Jan 10, 2022
Merged

fix(views): Use dot notation on entry-meta view includes #2941

Log1x merged 1 commit into from
Jan 10, 2022

Conversation

@Log1x
Copy link
Member

@Log1x Log1x commented Jan 10, 2022

I have no idea how this went unnoticed for so long lol

@Log1x Log1x requested a review from QWp6t January 10, 2022 22:07
@github-actions github-actions bot added php Pull requests that update PHP code views labels Jan 10, 2022
@Log1x Log1x requested a review from kalenjohnson January 10, 2022 22:13
kalenjohnson
kalenjohnson approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@kalenjohnson kalenjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess 😡

@Log1x Log1x merged commit fc53cf1 into main Jan 10, 2022
@Log1x Log1x deleted the fix/entry-meta-dot-notation branch January 10, 2022 22:16
@retlehs retlehs added this to the 10.0.0-beta.3 milestone Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QWp6t QWp6t Awaiting requested review from QWp6t

1 more reviewer

@kalenjohnson kalenjohnson kalenjohnson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

php Pull requests that update PHP code views

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Log1x @kalenjohnson @retlehs