Skip to content

Conversation

@kuralme
Copy link
Contributor

@kuralme kuralme commented Dec 9, 2025

Used tf frame prefix helper in mecanum drive controller to test as follow up changes

Related PR

- tests updated: one prefix enable test is left intentionally, but renamed
- deprecation info added to yaml
@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.89%. Comparing base (73bad72) to head (9b0467c).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
..._drive_controller/src/mecanum_drive_controller.cpp 60.00% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2063      +/-   ##
==========================================
- Coverage   84.93%   84.89%   -0.04%     
==========================================
  Files         148      148              
  Lines       14418    14408      -10     
  Branches     1238     1240       +2     
==========================================
- Hits        12246    12232      -14     
- Misses       1738     1739       +1     
- Partials      434      437       +3     
Flag Coverage Δ
unittests 84.89% <75.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
..._controller/test/test_mecanum_drive_controller.cpp 100.00% <100.00%> (ø)
..._controller/test/test_mecanum_drive_controller.hpp 87.50% <ø> (ø)
..._drive_controller/src/mecanum_drive_controller.cpp 88.30% <60.00%> (-1.36%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Juliaj Juliaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@christophfroehlich christophfroehlich merged commit abdaed1 into ros-controls:master Dec 16, 2025
16 of 18 checks passed
@github-project-automation github-project-automation bot moved this from Needs review to Done in Review triage Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants