Enforces reassembly of fragments to always be in enabled #775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlegDokuka
commented
Apr 9, 2020
rsocket-core/src/main/java/io/rsocket/fragmentation/FragmentationDuplexConnection.java
Outdated
Show resolved
Hide resolved
OlegDokuka
commented
Apr 9, 2020
rsocket-examples/src/main/java/io/rsocket/examples/transport/ws/WebSocketHeadersSample.java
Show resolved
Hide resolved
7eb4882 to
0343cb0
Compare
Member
Author
|
@rstoyanchev, in short, I moved reassembly logic from FragmentationDuplexConnection so, for now, Fragmentation does exactly fragmentation and now we have ReassemblyDuplexConnection which accompanies every other DuplexConnection in the know transports. Unfortunately, I'm not seeing simple way (without braking API) to built-in reassembly logic directly into the DuplexConnection interface. Any suggestions are welcome |
rstoyanchev
reviewed
Apr 15, 2020
Contributor
rstoyanchev
left a comment
There was a problem hiding this comment.
Looks good, just a suggestion to make ReassemblyDuplexConnection a base class.
rsocket-core/src/main/java/io/rsocket/fragmentation/FragmentationDuplexConnection.java
Outdated
Show resolved
Hide resolved
rsocket-transport-netty/src/main/java/io/rsocket/transport/netty/client/TcpClientTransport.java
Show resolved
Hide resolved
Signed-off-by: Oleh Dokuka <[email protected]>
…Connection Signed-off-by: Oleh Dokuka <[email protected]>
0343cb0 to
351ab63
Compare
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now, we have a bug in RSocket, related to the fact that one side may not directly setup fragmentation but another may.
Such miss-setup leads to the fact that one side is not able to reassemble back fragmented payload.
This PR provide fragment reassembling enforcement so every duplex connection is wrapped by a separate
ReassemblyDuplexConnectionwhich takes care of reassembling back fragments even if fragmentation is not enabledSigned-off-by: Oleh Dokuka [email protected]