Apply FragmentationDuplexConnection from a single place #836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7f2510a to
c3daf03
Compare
OlegDokuka
approved these changes
May 15, 2020
Member
OlegDokuka
left a comment
There was a problem hiding this comment.
LGTM in general. Few comments to consider
rsocket-core/src/main/java/io/rsocket/core/RSocketConnector.java
Outdated
Show resolved
Hide resolved
rsocket-core/src/main/java/io/rsocket/fragmentation/FragmentationDuplexConnection.java
Outdated
Show resolved
Hide resolved
rsocket-core/src/main/java/io/rsocket/fragmentation/FragmentationDuplexConnection.java
Show resolved
Hide resolved
rsocket-core/src/main/java/io/rsocket/fragmentation/ReassemblyDuplexConnection.java
Outdated
Show resolved
Hide resolved
c3daf03 to
8817dac
Compare
Contributor
Author
|
I've cleaned up further as suggested. |
The flags were introduced in rsocket#585 such that when fragmentation is enabled, it takes over the encoding and decoding of the frame length instead of the underlying transport. However this doesn't seem to have any obvious purpose. On the sending side, fragmentation breaks down the frames and then the transport can add the length just as well. On the receiving side, the transport is first anyway. It's better to simplify this and leave it to transports to decide this whether a length is needed and expected. Signed-off-by: Rossen Stoyanchev <[email protected]>
The flag was added in b15a1f so transports can decorate with a FragmentationDuplexConnection but the logic is the same everywhere and can be applied from a single place without the transport having to know about it. Signed-off-by: Rossen Stoyanchev <[email protected]>
8817dac to
207e684
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In b15a1fc transports started applying
FragmentationDuplexConnection. This was probably done so that TCP transports can give up control of dealing with the frame length to the fragmentation layer. However on closer look there is no obvious reason to not leave the frame length to transports to deal with.The two commits here restore fragmentation being applied from a single place and make transports unaware of that logic eliminating duplication in the process.