ensures streams are terminated if racing terminal and new stream #848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
98d6b03 to
b84392b
Compare
Signed-off-by: Oleh Dokuka <[email protected]>
b84392b to
d12d5dc
Compare
rstoyanchev
approved these changes
May 26, 2020
OlegDokuka
added a commit
that referenced
this pull request
Jun 1, 2020
Signed-off-by: Oleh Dokuka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #846
This PR fixes the case when a new stream might have already been started but the terminal error was not put into the list, so the termination will omit that "half initiated" one so it will hang forever since UnboundedProcessor does not error when calling onNext.
As a fix, the termination operation is scheduled on the
serializedSchedulerso there is no racing between new requests and termination. Also, all the streams that were scheduled but have not observed termination do this check again on the first request method so if there is termination, this stream will be terminated immediatelySigned-off-by: Oleh Dokuka [email protected]