Skip to content

Add inlay hint support per LSP specification. #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

xeger
Copy link
Contributor

@xeger xeger commented Jul 3, 2022

Closes #103.

I'm retaining the support for the old-style RPC for now to avoid breaking the VS Code extension. I guess we'd technically increment the minor version of syntax_tree, release a new cut of the extension, and then increment the major version of syntax_tree when removing support for the proprietary stuff! What a pain.

It begs the question: should the LSP server be built into the syntax_tree gem, if it's likely to change frequently? I suppose that depends on the future of the parsing and formatting functions -- if some or all of the gem will be accepted as a built-in gem, then perhaps that would be a good time to split it up.

@kddnewton
Copy link
Member

I'm not confident that core will ever want to actually merge this tbh, so I doubt it'll become a default gem unfortunately.

Yeah, let's go through the necessary process that you described above. I'll release a minor version after I merge this.

@kddnewton kddnewton merged commit 398cf3b into ruby-syntax-tree:main Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework inlay hints to match the spec
2 participants