Detect integration tests in is_in_test#16786
Open
ClementTsang wants to merge 4 commits intorust-lang:masterfrom
Open
Detect integration tests in is_in_test#16786ClementTsang wants to merge 4 commits intorust-lang:masterfrom
is_in_test#16786ClementTsang wants to merge 4 commits intorust-lang:masterfrom
Conversation
Collaborator
|
r? @dswij rustbot has assigned @dswij. Use Why was this reviewer chosen?The reviewer was selected based on:
|
d96fa88 to
e3772c6
Compare
Author
|
Hmmm it looks like it's causing problems because now some of clippy's tests are being treated as valid under |
10d22da to
07033e9
Compare
Seems like the integration test check trips the ui tests, wasn't sure about this or whether I should adjust all the existing failing tests.
4588d65 to
d234340
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #13981
This PR makes it so that the
is_in_testcheck accounts for if a node is in an integration test file (that is, undertests/). This should fix the issue where some clippy settings work forcfg(test)but not for integration tests.This could be extended to
benchesas well if this seems reasonable.Note that this is the first time I'm contributing to this repo, so please let me know if there's anything to change. I'm not really sure how I was meant to test this for example, especially if I want to test an example of this where it should still "fail", I guess (should I split the
integration_testwith two crates?).changelog: [
unwrap-used]:allow-unwrap-in-testsworks now on integration tests.