feat(lint): Add missing_no_std_attribute#16974
Open
bushrat011899 wants to merge 1 commit intorust-lang:masterfrom
Open
feat(lint): Add missing_no_std_attribute#16974bushrat011899 wants to merge 1 commit intorust-lang:masterfrom
missing_no_std_attribute#16974bushrat011899 wants to merge 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
r? @Jarcho rustbot has assigned @Jarcho. Use Why was this reviewer chosen?The reviewer was selected based on:
|
1a3eda3 to
61ef36d
Compare
|
Lintcheck changes for 61ef36d
This comment will be updated if you push new changes |
Author
|
@rustbot author Looks like the |
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
#![no_std]but aren't #1569Details
This lint checks if a crate does not contain the
#![no_std]attribute (either bare or throughcfg_attr) and suggests adding both it andextern crate std;.This suggestion is inserted at the
ModSpans::inject_use_spanpoint.Notes
std::prelude. I have marked it asApplicability::MaybeIncorrectto reflect this.changelog: [
missing_no_std_attribute]: add new lint for lack of#![no_std]attribute