Skip to content

Remove feature(const_closures) from libcore #126737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Jun 20, 2024
Merged

Remove feature(const_closures) from libcore #126737

bors merged 1 commit into from
Jun 20, 2024

Conversation

@fee1-dead
Copy link
Member

@fee1-dead fee1-dead commented Jun 20, 2024

This is an incomplete feature and apparently it has no uses in core. Incomplete features should generally not be used in our standard library.

@rustbot
Copy link
Collaborator

rustbot commented Jun 20, 2024

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 20, 2024
@compiler-errors
Copy link
Member

compiler-errors commented Jun 20, 2024

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 20, 2024

📌 Commit d3091df has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 20, 2024
Merged
@bors bors merged commit b0b2082 into rust-lang:master Jun 20, 2024
@rustbot rustbot added this to the 1.81.0 milestone Jun 20, 2024
@fee1-dead fee1-dead deleted the rm-const-closures branch June 24, 2024 05:41
@fee1-dead fee1-dead added the PG-const-traits Project group: Const traits label Aug 9, 2024
@fee1-dead fee1-dead mentioned this pull request Aug 25, 2024
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@compiler-errors compiler-errors

Labels

PG-const-traits Project group: Const traits S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.81.0

Development

Successfully merging this pull request may close these issues.

5 participants

@fee1-dead @rustbot @compiler-errors @bors @cuviper