Skip to content

Elide clone operation when calling iter::Cloned::advance_{back}_by() #90209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
the8472 wants to merge 4 commits into from
Closed

Elide clone operation when calling iter::Cloned::advance_{back}_by() #90209

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ee9ce6b
Elide clone operation when calling `iter::Cloned::advance_{back}_by()`
the8472 Oct 23, 2021
67cdc89
elide unnecessary clones in `iter::Cloned::{last, count}`
the8472 Jan 6, 2022
fe6ff67
Use advance_by instead of nth in `Skip::next`
the8472 Jan 6, 2022
37206a2
add tests for iter::Cloned optimizations
the8472 Jan 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use advance_by instead of nth in Skip::next 
Combined with the `iter::Cloned::advance_by` implementation this leads to fewer clone operations
  • Loading branch information
@the8472
the8472 committed Jan 6, 2022
commit fe6ff67df19fbcf57fbc8e0ec00b2d96abd69b80
2 changes: 1 addition & 1 deletion library/core/src/iter/adapters/skip.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ where
#[inline]
fn next(&mut self) -> Option<I::Item> {
if unlikely(self.n > 0) {
self.iter.nth(crate::mem::take(&mut self.n) - 1);
let _ = self.iter.advance_by(crate::mem::take(&mut self.n));
}
self.iter.next()
}
Expand Down