Added support for custom line widths with a test #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samwho
requested changes
Jul 21, 2025
Owner
samwho
left a comment
There was a problem hiding this comment.
Congrats on your first open source contribution! I'm honoured it's one of my repos. :)
Just one small request and then we can get this merged and released.
Owner
|
This was released as part of v0.4.5. Congrats 😁 |
Contributor
Author
|
Awesome, thanks! I really appreciate the opportunity to contribute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #29, I have added a new argument to be able to specify the number of dash characters to be displayed on a single line, along with a single test to ensure that the correct number of dashes is displayed.
This is my first time contributing to an open source project so any feedback is welcome!