Repository navigation
fix(navigator): let Type/Experience filter lists render fully (#1595) - #1598
Merged
Merged
Conversation
The Filter Your Search 'Type' column has 5 checkboxes plus a divider, exceeding the 7.5rem max-height/overflow-y:auto scroll cap that is meant for the long dynamic Topic and Software Product lists. That forced users to scroll the Type list even though the column has ample vertical space alongside the taller (search-box + list) Topic/Product columns. Add a .filter-list--static modifier that lifts the height cap for the fixed-length Type and Experience lists so they render fully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1595
Problem
On the Tutorial Navigator, the Filter Your Search Type column forced users to scroll its list even though there was ample vertical space to render it fully.
Root cause
.filter-listis capped atmax-height: 7.5remwithoverflow-y: auto. That cap exists for the long, dynamic Topic and Software Product lists. The Type column has 5 checkboxes plus a divider (Mission / Group / Tutorial / — / New tutorials / No license), which exceeds 7.5rem and therefore scrolled — while the Topic/Product columns look taller overall because they also carry a search box above their list.Fix
Add a
.filter-list--staticmodifier (applied to the fixed-length Type and Experience lists) that lifts the height cap so they render fully. The dynamic Topic/Software Product lists keep their scroll cap.CSS-only change; no filtering logic touched.
Verification
npx vite buildinhugo-apps/passes;navigator.jsemitted.main(verified identical pass/fail counts with the change stashed) — snapshot/env drift unrelated to this change.