Repository navigation
chore(deploy): bump prod tutorials-srv instances 2->4 for launch load - #1643
Merged
Merged
Conversation
Reconcile prod.mtaext with a live cockpit `cf scale`: prod tutorials-srv is running 4 instances for developers.sap.com site-launch load, but the pin was 2 — the next deploy would have reverted it. Bake in 4 so it sticks. Approuter left at 2. Rate-limiter caveat noted inline: ip-rate-limit.js + chat-rate-limit.js are in-process, so caps now run per-instance at 4x aggregate; accepted as launch headroom. Patch bump 1.13.4 -> 1.13.5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bump prod
tutorials-srvfrom 2 → 4 instances indeploy/prod.mtaext. Approuter stays at 2. Patch version bump1.13.4 → 1.13.5.Why
Prod
tutorials-srvis already running 4 instances (verified live viacf app) to absorb developers.sap.com site-launch load, butprod.mtaextpinned it to 2 — so the nextcf deploywould have reverted it to 2. This reconciles config to the running state, same treatment as the disk-quota fix (#1635).The rate limiters in
srv/lib/ip-rate-limit.jsandsrv/lib/chat-rate-limit.jsare in-process, so at 4 instances the per-instance caps run at ~4× the intended aggregate. Accepted as launch headroom here; the basemta.yamlcomment flags this. Follow-up if 4 becomes steady state: move those limits to a shared store.Changes
deploy/prod.mtaext:tutorials-srvinstances: 2 → 4(+ rationale comment).deploy/mta.yaml: version1.13.4 → 1.13.5No code changes; deploy config only.