Repository navigation
fix(embed): hide More-from-author rail in embed mode - #1765
Merged
Merged
Conversation
Release v1.14.0: What's New page, author detail pages, Devtoberfest Signups report
The #1732 'More from this author' rail is cross-tutorial navigation the host page owns. In any embed mode (none/minimal/reader) an embedded tutorial should stay focused on its own content, so hide the rail via html[data-embed] .more-from-author — mirroring the existing footer / breadcrumbs / feedback-share embed-hide rules. Adds an e2e guard that the rail is present without embed and hidden under ?embed=minimal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When a tutorial renders in embed mode (
html[data-embed]=none/minimal/reader), the #1732 "More from this author" rail is now hidden.Why
The author rail is cross-tutorial navigation the host page owns. An embedded tutorial should stay focused on its own content — same rationale as the existing embed-hide rules for footer, breadcrumbs, and feedback-share.
How
hugo/assets/css/ui5-overrides.css:html[data-embed] .more-from-author { display: none !important; }, placed alongside the other universal-embed hide rules. (ui5-overrides.cssis served as-is — not postcss-built — so no CSS rebuild needed.)test/e2e/other-tutorials-by-author.test.js: added a guard that the rail is visible without embed and hidden under?embed=minimal. Self-skips whenSMOKE_BASE_URL/PLAYWRIGHT_BASE_URLis absent (runs in the post-DEV-deploye2eCI job).The non-embed path is unchanged; the existing "tutorial page shows the more-from-author rail" test still passes.