Repository navigation
fix(ci): allowlist srv-only publish-contributors + publish-validation-rules routes - #2091
Merged
Merged
Conversation
…-rules routes WS2/WS3 added POST /content/publish-contributors and /content/publish-validation-rules to srv/server.js plus channel=qa skips in publish-content.ts, but did not update the route-drift guard's ALLOWLIST_ONLY_ON_SRV. Both are intentionally srv-only (srv-qa has no ContributorCache/ValidationRules entity — POST would 404/500, and no QA runtime reader), same rationale as validate-answer-specs (#1375). Fixes the failing 'Static build guards (postbuild:apps)' CI step on DEV.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI unit-tests job fails at the Static build guards (postbuild:apps) step on DEV:
Root cause
WS2/WS3 added
POST /content/publish-contributorsandPOST /content/publish-validation-rulestosrv/server.js, and addedchannel=qaskips for both inscripts/publish-content.ts— but did not update the route-drift guard'sALLOWLIST_ONLY_ON_SRV.Both routes are intentionally srv-only: srv-qa has no
ContributorCache/ValidationRulesentity (the QA modelcom.sap.developers.ims.qadoesn't load them, POST would 404/500), and there is no QA runtime reader. This is exactly thevalidate-answer-specs(#1375) pattern.Fix
Add both routes to
ALLOWLIST_ONLY_ON_SRVwith justifications. Guard now passes (OK — 30 /content/* on srv, 13 on srv-qa). Unit tests themselves were already green; only this guard step was red.