Repository navigation
fix(channels): hub UX — crosswalk 404, media-diet layout, health enrichment - #2173
Merged
Merged
Conversation
…enrich health - ChannelsDirectory: remove Learn↔Follow hub card linking to /channels/crosswalk/ (page was never built; xs-app.json reserves but does not serve it → 404). Crosswalk data already surfaces on topic pages + channel-detail pages. - MediaDiet: two-column layout (sticky picker rail + results), live match count so results are never invisible below the fold, raise focus-area cap 3→6. - ChannelsHealth: add narrative summary, active-rate % headline (color-coded good/warn/poor), proportion bars per panel, and 'thin' coverage flags — replaces the bare number table. No new data fields required. Tests updated: hub band 4→3 cards + no-crosswalk assertion; media-diet cap→6 + live-count; health narrative + active-rate. 32/32 island tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses live-DEV QA feedback on the channels hub subsystem.
Changes
1. Crosswalk 404 (bug). The directory's Learn ↔ Follow hub card linked to
/channels/crosswalk/, but that page was never built —xs-app.jsonreserves the route (excludes it from the channel-detail catch-all) yet nothing serves it, so the link dead-ended at 404. Removed the card. The crosswalk data already surfaces both directions: Related channels bands on/topics/*pages and the topics section on channel-detail pages.2. Media Diet layout + cap. The full-width tag list pushed results below the fold, so users couldn't tell they had matches. Now a two-column layout (sticky focus-area picker rail + results column) with a live
N channels match your dietcount. Focus-area selection cap raised 3 → 6 (12-result display cap retained).3. Ecosystem Health enrichment. Replaced the bare number table with: a one-line narrative summary, an active-rate % headline (color-coded good ≥60 / warn ≥35 / poor), proportion bars on each breakdown panel, and thin-coverage flags on under-covered categories. No new backend data fields — all derived from the existing
/buildstats DTO.Tests
/channels/crosswalk/assertionvitest --project unitacross the 3 islands)Deploy note
Island source changes — go live only after a build that rebundles the islands (full
build:all→mbt build/deploy). A--skip-buildor content-only rebuild won't ship them.