Repository navigation
fix(admin): close unterminated JSDoc that broke Job Board (#2488) - #2502
Merged
Merged
Conversation
The #2488 sort refactor left an empty, unterminated /** immediately before _callListJobs, swallowing _callListJobs, _callListRunningJobs, and _loadJobLastRunRows into a comment. onInit -> _loadJobControls then threw "TypeError: this._callListJobs is not a function" and the Job Board admin UI failed to open (regression shipped in 1.31.4). Restore the JSDoc closer so the three methods attach to the controller. node --check passes; no unclosed-comment pattern remains.
This was referenced Sep 25, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The #2488 sort refactor left an empty, unterminated /** immediately
before _callListJobs, swallowing _callListJobs, _callListRunningJobs,
and _loadJobLastRunRows into a comment. onInit -> _loadJobControls then
threw "TypeError: this._callListJobs is not a function" and the Job Board
admin UI failed to open (regression shipped in 1.31.4).
Restore the JSDoc closer so the three methods attach to the controller.
node --check passes; no unclosed-comment pattern remains.
Impact
Prod regression shipped in 1.31.4. The Job Board admin UI (
/admin-ui/) fails to open:Root cause
The #2488 sort feature (
a93c8f769) insertedonJobSortChangeand left an empty, unterminated/**on the line before_callListJobs. JS parses that as an open block comment running until the next*/, which swallowed three method definitions —_callListJobs,_callListRunningJobs,_loadJobLastRunRows— so they never attached to the controller.Fix
Restore the JSDoc closer (
*/) with a proper comment for_callListJobs. One-region change, no logic touched.Verification
node --checkpasses on the controller./**-immediately-before-method (unclosed-JSDoc) pattern in the file.Fix goes DEV→main via release promotion (no main-hotfix path). Needs a full admin-UI deploy (bundle-gated).