Skip to content

fix(admin): close unterminated JSDoc that broke Job Board (#2488) - #2502

Merged
jung-thomas merged 1 commit into
DEVfrom
fix/job-board-jsdoc-2488
Sep 24, 2026
Merged

jung-thomas merged 1 commit into
DEVfrom
fix/job-board-jsdoc-2488

Conversation

@jung-thomas

Copy link
Copy Markdown
Contributor

The #2488 sort refactor left an empty, unterminated /** immediately
before _callListJobs, swallowing _callListJobs, _callListRunningJobs,
and _loadJobLastRunRows into a comment. onInit -> _loadJobControls then
threw "TypeError: this._callListJobs is not a function" and the Job Board
admin UI failed to open (regression shipped in 1.31.4).

Restore the JSDoc closer so the three methods attach to the controller.
node --check passes; no unclosed-comment pattern remains.

Impact

Prod regression shipped in 1.31.4. The Job Board admin UI (/admin-ui/) fails to open:

Uncaught (in promise) TypeError: this._callListJobs is not a function
    at Board.controller.js:87 (_loadJobControls)  ← onInit

Root cause

The #2488 sort feature (a93c8f769) inserted onJobSortChange and left an empty, unterminated /** on the line before _callListJobs. JS parses that as an open block comment running until the next */, which swallowed three method definitions — _callListJobs, _callListRunningJobs, _loadJobLastRunRows — so they never attached to the controller.

Fix

Restore the JSDoc closer (*/) with a proper comment for _callListJobs. One-region change, no logic touched.

Verification

  • node --check passes on the controller.
  • No remaining /**-immediately-before-method (unclosed-JSDoc) pattern in the file.
  • The three methods are now real object properties (confirmed by definition scan).

Fix goes DEV→main via release promotion (no main-hotfix path). Needs a full admin-UI deploy (bundle-gated).

The #2488 sort refactor left an empty, unterminated /** immediately
before _callListJobs, swallowing _callListJobs, _callListRunningJobs,
and _loadJobLastRunRows into a comment. onInit -> _loadJobControls then
threw "TypeError: this._callListJobs is not a function" and the Job Board
admin UI failed to open (regression shipped in 1.31.4).

Restore the JSDoc closer so the three methods attach to the controller.
node --check passes; no unclosed-comment pattern remains.
@jung-thomas
jung-thomas merged commit 079e56a into DEV Sep 24, 2026
5 checks passed
@jung-thomas
jung-thomas deleted the fix/job-board-jsdoc-2488 branch September 24, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant