Repository navigation
fix(deploy): replace bogus --parallel-resource-upload flag with MULTIAPPS_UPLOAD_CHUNKS_SEQUENTIALLY env var - #2563
Merged
Conversation
…APPS_UPLOAD_CHUNKS_SEQUENTIALLY env var `--parallel-resource-upload` is not a real MultiApps CLI plugin flag (verified: latest plugin v3.11.1 has no such flag). `cf deploy` rejects it with "Unknown or wrong flags: --parallel-resource-upload", which broke EVERY scripted deploy via `npm run deploy` since it was introduced in de087a2 (PR #2553). Replace it with the real supported env var MULTIAPPS_UPLOAD_CHUNKS_SEQUENTIALLY=false (parallel chunk upload), which is already the plugin default — behavior is unchanged, intent is documented. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
scripts/deploy-mta.cjs(Step 4) passed--parallel-resource-uploadtocf deploy. That is not a real MultiApps CLI plugin flag — verified against the latest plugin (v3.11.1), which has no such flag.cf deployrejects it with:This broke every scripted deploy via
npm run deploy. The flag was introduced in de087a2 (PR #2553).Fix
Replace the bogus CLI flag with the real supported env var
MULTIAPPS_UPLOAD_CHUNKS_SEQUENTIALLY=false(parallel chunk upload). Percf deployhelp: "Upload chunks sequentially instead of in parallel. By default is false."falseis already the plugin default, so behavior is unchanged — setting it explicitly just documents intent.sh('cf', …)call via{ env: cfDeployEnv }, mirroring how the build step passesCAP_BASE_URL.--dry-runpreview line is updated to show the env-var form and no longer prints the bogus flag.Verification
node --check scripts/deploy-mta.cjspasses.node scripts/deploy-mta.cjs --env dev --dry-runStep-4 preview now reads:MULTIAPPS_UPLOAD_CHUNKS_SEQUENTIALLY=false cf deploy mta_archives/<newest>.mtar -e ../deploy/dev.mtaext -f— no--parallel-resource-upload.grep -rn -- '--parallel-resource-upload' scripts/ docs/matches only the explanatory comment; no functional/doc reference remains.🤖 Generated with Claude Code