Repository navigation
docs: follow-up for /signin IdP re-selection over active IAS SSO session - #2626
Merged
Merged
Conversation
Release 1.34.0 — GitHub login + RPT sign-in page (DEV→main)
Documents the known SSO-reuse limitation (shipped 1.34.0): clicking a provider button on /signin while an IAS session exists reuses that session instead of honoring the chosen IdP. Root cause: approuter v23 cannot send OIDC prompt=login (closed authorize-URL query set; hand-rolling breaks the state/PKCE callback). Fix is IAS-side: a Conditional Authentication rule forcing re-auth when a corporate idp is requested (preferred), or a dedicated force-auth IAS app (fallback) — scoped so the seamless returning-visitor path stays silent. Needs IAS admin.
jung-thomas
added a commit
that referenced
this pull request
Oct 4, 2026
…udge feat(signin): nudge to sign out before switching IdP over an active IAS session (#2626 follow-up)
This was referenced Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the known SSO-reuse limitation shipped in 1.34.0 and the IAS-side fix path.
Symptom: clicking a provider button on /signin while an IAS session is active reuses that session instead of honoring the chosen IdP (only affects switching mid-session; logged-out users are fine).
Why it's IAS-side: approuter v23 can't send OIDC prompt=login (closed authorize-URL query set; hand-rolling the URL breaks the approuter's state/PKCE callback — both protections are on by default). XSUAA has no per-request toggle.
Fix: IAS Conditional Authentication rule forcing re-auth when a corporate idp is requested (preferred, scalpel), or a dedicated force-auth IAS app (fallback) — scoped so the seamless returning-visitor path stays silent. Needs IAS admin on tenant atxgsg7zi; no repo code change for the conditional-auth path.