171 add auto cache clearing #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Collaborator
Author
|
@sauravpanda please review this once |
sauravpanda
requested changes
Mar 19, 2025
src/engines/mlc-engine-wrapper.ts
Outdated
| // SmolLM2-135M-Instruct | ||
| /\/([\w\.-]+)\-(\d+\.?\d*[BM])\-Instruct/, | ||
| // SmolLM2-135M | ||
| /\/([\w\.-]+)\-(\d+\.?\d*[BM])/ |
Owner
There was a problem hiding this comment.
I think this pattern may not have all the model names.
Collaborator
Author
There was a problem hiding this comment.
Okay, let me recheck
| clean: true, | ||
| sourcemap: true, | ||
| treeshake: true, | ||
| treeshake: false, |
Collaborator
Author
There was a problem hiding this comment.
If we set treeshake as true, and the function we write is not used within code, it skips exporting it. The clearModelCache function needs it
sauravpanda
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.