Refine pattern-matching.md #1330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think the "many" is short for "more than 2? woah, that's too many to count". Why do you prefer "number"? |
Contributor
Author
|
I like "many" a lot. It's very clear, but zero and negative numbers do not match "many" definition. |
Member
|
Ah, I see your point. Perhaps "other", then. And maybe even mention the fact that the int returned by |
Contributor
Author
|
Exactly what is needed! |
dwijnand
approved these changes
May 19, 2019
SethTisue
approved these changes
May 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
number is a better name than many here.