Match type trace improvements #20178
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`MatchTypeTrace.recurseWith` will restore the previous entries if op succeeds, which is the true as long one reduction could be done, but we may miss an underlying failed reduction that was attempted. The issue could not be detected without separate compilation, since the successful normalizations already happened in `TypeOps#simplify`.
|
@EugeneFlesselle @sjrd what's the status of this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normalize before attempting to record a failed match type reduction.
MatchTypeTrace.recurseWithwill restore the previous entries if op succeeds, which is the true as long one reduction could be done, but we may miss an underlying failed reduction that was attempted.Also dealias aliased applied match aliases, which are not quite applied match aliases and therefore not attempted to reduce on a
tryNormalize.