EnjoyHQ Destination Docs #1225
Merged
EnjoyHQ Destination Docs #1225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for segment-docs-preview ready! Built with commit 6028f6b https://deploy-preview-1225--segment-docs-preview.netlify.app |
sanscontext
reviewed
Nov 24, 2020
sanscontext
reviewed
Nov 24, 2020
sanscontext
reviewed
Nov 24, 2020
sanscontext
reviewed
Nov 24, 2020
sanscontext
reviewed
Nov 24, 2020
sanscontext
reviewed
Nov 24, 2020
sanscontext
reviewed
Nov 24, 2020
sanscontext
reviewed
Nov 24, 2020
Contributor
|
Asking for a few changes. :) I think we're still seeing that |
Co-authored-by: LRubin <[email protected]>
Co-authored-by: LRubin <[email protected]>
Co-authored-by: LRubin <[email protected]>
Co-authored-by: LRubin <[email protected]>
Co-authored-by: LRubin <[email protected]>
Co-authored-by: LRubin <[email protected]>
Co-authored-by: LRubin <[email protected]>
Co-authored-by: LRubin <[email protected]>
Contributor
Author
Thank you for yet another thorough review @sanscontext. I've resolved the issues you outlined. I'll take a look into what can be done about that make catalog issue. |
Contributor
Author
|
@sanscontext I'm ready to add the updated destination.yml as soon as you approve this one :) |
Contributor
|
Looks good! And it looks like |
sanscontext
approved these changes
Nov 30, 2020
imklau
pushed a commit
that referenced
this pull request
Dec 2, 2020
* selligent marketing cloud docs * make catalog * Update src/connections/sources/catalog/cloud-apps/selligent-marketing-cloud/index.md Co-authored-by: LRubin <[email protected]> * destination blurb + source-type: event * dest blurb * lazy-lantern name change * rename folder to lantern * DOC-97 remove extra /docs * DOC-45 remove note, pending Nick's confirmation (#1227) * remove note, pending Nick's confirmation * fix message Signed-off-by: sanscontext <[email protected]> * Specifies that Google Adwords Remarketing Lists is in fact a Personas List Destination (#1174) Co-authored-by: LRubin <[email protected]> * make catalog * resolving lantern conflict * make catalog * remove note about time delay (#1263) Per Nick and the FB team, this delay no longer happens. :) * selligent marketing cloud docs * make catalog * destination blurb + source-type: event * Update src/connections/sources/catalog/cloud-apps/selligent-marketing-cloud/index.md Co-authored-by: LRubin <[email protected]> * dest blurb * make catalog * make catalog * remake catalog just to be sure. * add note (#1228) * EnjoyHQ Destination Docs (#1225) * EnjoyHQ Destination Docs * Update src/connections/destinations/catalog/enjoyhq/index.md Co-authored-by: LRubin <[email protected]> * Update src/connections/destinations/catalog/enjoyhq/index.md Co-authored-by: LRubin <[email protected]> * Update src/connections/destinations/catalog/enjoyhq/index.md Co-authored-by: LRubin <[email protected]> * Update src/connections/destinations/catalog/enjoyhq/index.md Co-authored-by: LRubin <[email protected]> * Update src/connections/destinations/catalog/enjoyhq/index.md Co-authored-by: LRubin <[email protected]> * Update src/connections/destinations/catalog/enjoyhq/index.md Co-authored-by: LRubin <[email protected]> * Update src/connections/destinations/catalog/enjoyhq/index.md Co-authored-by: LRubin <[email protected]> * Update src/connections/destinations/catalog/enjoyhq/index.md Co-authored-by: LRubin <[email protected]> * updates destinations.yml Co-authored-by: Shamil Ataev <[email protected]> Co-authored-by: LRubin <[email protected]> * refactor: Reskin feedback styles * refactor: styles of sidebar feedback component * wip * wip * revert * wip() * wip * fix * fix * fix * fix * Update index.js Co-authored-by: Paul Yoo <[email protected]> Co-authored-by: pauljaeinyoo <[email protected]> Co-authored-by: LRubin <[email protected]> Co-authored-by: markzegarelli <[email protected]> Co-authored-by: markzegarelli <[email protected]> Co-authored-by: Charlie Gerrior <[email protected]> Co-authored-by: sanscontext <[email protected]> Co-authored-by: Shamil Ataev <[email protected]> Co-authored-by: Shamil Ataev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This is the destination doc for the integration EnjoyHQ. Once approved, I will add the result of make catalog and I will merge. Let me know if there's any improvement you see @markzegarelli @sanscontext, thank you.
Please do not merge! I will add the updated destinations.yml and merge with that once approved :)
Merge timing
I will merge myself once the doc piece is approved. I will add the latest updated
destination.ymlfile, which is generated via themake catalogcommand and once that's added, I will merge.