-
Notifications
You must be signed in to change notification settings - Fork 10
config: migrate to stylistic eslint rules without observed impact #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
onebytegone
merged 29 commits into
silvermine:master
from
MatheusBaldi:MatheusBaldi/migrate-rules-without-observed-impact
Feb 18, 2025
Merged
config: migrate to stylistic eslint rules without observed impact #118
onebytegone
merged 29 commits into
silvermine:master
from
MatheusBaldi:MatheusBaldi/migrate-rules-without-observed-impact
Feb 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrMarCode
approved these changes
Feb 13, 2025
MrMarCode
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
53b56b6 to
48527fe
Compare
onebytegone
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
#115
Description
After migrating these rules to stylistic, these rules didn't raise any linting errors in the project the changes were tested. I doesn't mean that this will be the case for every project, but based in my testing sample, the likelyhood is lower.